chore(.generator): remove legacy generate impl#17170
Open
noahdietz wants to merge 5 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the CI process by removing the library generation and building steps from cloudbuild-test.yaml, leaving only the generator image build verification. Additionally, two JSON metadata files for google-cloud-language were deleted. The reviewer suggests optimizing the build resources by reducing the timeout and machine type, and using the --no-push flag for Kaniko to avoid potential tag collisions during pull request builds.
noahdietz
changed the title
noahdietz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the legacylibrarian Python container implementation and test for
generate, which is no longer maintained or used.The image build step is retained for build verification triggered by changes to the
.generator/directory. Unit tests otherwise cover the code therein.Reduces coverage requirement for
.generatorfrom100to95(the check failed bc it went from100to99.4)